internal: calculate pattern adjustments #9105
Conversation
| @@ -331,8 +331,7 @@ impl<'a> MatchCheckCtx<'a> { | |||
|
|
|||
| #[track_caller] | |||
| pub(super) fn bug(&self, info: &str) -> ! { | |||
There was a problem hiding this comment.
(note: I haven't checked where this is called, but in general we want to be a bit more resilient about panicking on errors than rustc: Showing some inaccurate information in the IDE is often better than breaking completely. Hence the always! macro etc. that panic on debug assertions, but only log and continue in release builds. In the case of match check, it'd be ideal if we could just skip the match if we encounter some bug condition, if it's not too complicated to do.)
There was a problem hiding this comment.
Interesting. This is worth some experimenting with fallible implementation then including it into future libraryfied match checking.
For now it just relies on correct lowering and filtering out erroneous input in match_check::PatCtxt::lower_pattern. But in case of bugs, yeah.. that's bad.
There was a problem hiding this comment.
Note, it's not worth making functions return results to avoid assertions. It's just, if there's a straightforward way to e.g. return no errors instead of panicking on an assertion, we should do that.
10213: minor: Improve resilience of match checking r=flodiebold a=iDawer In bug condition the match checking strives to recover giving false no-error diagnostic. Suggested in #9105 (comment) Co-authored-by: Dawer <[email protected]>
This extends
InferenceResultwithpub pat_adjustments: FxHashMap<PatId, Vec<Ty>>.Fixes #9095