Add extract_assignment assist #7130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jesse-Bakker
force-pushed
the
extract-assignment
branch
2 times, most recently
from
dccf19d to
3e2159a
Compare
Jesse-Bakker
changed the title
Veykril
reviewed
Jan 2, 2021
Jesse-Bakker
force-pushed
the
extract-assignment
branch
2 times, most recently
from
a449402 to
22c3a62
Compare
|
Added support for match. Getting correct indentation is a bit of a PITA and I'm not sure if I did it correctly |
Veykril
reviewed
Jan 2, 2021
|
Yes indentation is an unsolved problem still iirc hence why its not so nice to do for now. Ideally we would be able to just format the produced syntax but thats yet to be done. LGTM overall, just a small nit left, if that doesn't work as I imagined feel free to ignore it. |
|
✌️ Jesse-Bakker can now approve this pull request. To approve and merge a pull request, simply reply with |
Jesse-Bakker
force-pushed
the
extract-assignment
branch
from
22c3a62 to
bfe6a8e
Compare
|
bors r+ |
|
Build succeeded! And happy new year! 🎉 |
|
See #4182 for indent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add extract-assignment assist (#7006).
Assist is for now only implemented on if/match-statements where the assigment is the last statement in every block,
as for other cases, one would have to check whether the assignment has effects on the rest of the block and
extract a temporary variable for it in the block.