Enable SemanticTokens on the client

[kjeremy]

This will crash the extension on stable and insiders without the "--enable-proposed-api matklad.rust-analyzer" command line switch.

See #3159 (comment)

[matklad]

I think we can just hide this behind a config setting. I am more worried that it's impossible to publish an extension with proposed API....

[kjeremy]

I think maybe on insiders I didn't need the json change but on stable I did. I can double-check that this afternoon.

…

On Wed, Feb 26, 2020, 8:50 AM Aleksey Kladov ***@***.***> wrote: I think we can just hide this behind a config setting. I am more worried that it's impossible to publish an extension with proposed API.... — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3321>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABBACRGWGS2EPDYSD4PG6RTREZXTDANCNFSM4K4FUSKA> .

[matklad]

I'll merge this and add a config flag

[kjeremy]

@matklad there is a editor.semanticHighlighting.enabled settings in vscode... maybe we could key off that? I am assuming the feature will once stabilized.

[matklad]

Hm, I would assume that it means some entirely different thing: it's stable while the feature itself is preview. Is this about handle_document_highlight perhaps?

[kjeremy]

I don't think so (see https://github.com/microsoft/vscode/wiki/Semantic-Highlighting-Overview, which also shows us how to support new token types and modifiers). handle_document_highlight is for textDocument/documentHighlight which fuzzily highlights a symbol with optional read/write.

[matklad]

yeah, you are right. Still, I think it makes sense to stick with plugin-specific default. Maybe someone want to use semantic tokens for Java, but not Rust.

Also, I am playing with this functionality now, and it is super awesome. Thank you @kjeremy for spearheading this! I've also pushed https://github.com/rust-analyzer/minimal-rust to disable textmate based highlighting, for debuggin.