Skip to content

fix: Fix SyntaxContextID using incorrect self IDs #16224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 1, 2024

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Jan 1, 2024

Follow up to #16200, there was another logical bug there.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 1, 2024
@Veykril
Copy link
Member Author

Veykril commented Jan 1, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Jan 1, 2024

📌 Commit 0c3fbba has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jan 1, 2024

⌛ Testing commit 0c3fbba with merge 9db5155...

@bors
Copy link
Contributor

bors commented Jan 1, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 9db5155 to master...

@bors bors merged commit 9db5155 into rust-lang:master Jan 1, 2024
@lnicola
Copy link
Member

lnicola commented Jan 1, 2024

I've triggered a new nightly and will do today's release afterwards.

@Veykril
Copy link
Member Author

Veykril commented Jan 1, 2024

Note this one wont cause panics, it might just cause macro $crate hygiene to resolve incorrectly.

@Veykril Veykril deleted the syntax-ctx branch January 1, 2024 12:30
@lnicola
Copy link
Member

lnicola commented Jan 1, 2024

Aaand it's out. Happy New Year everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants