Skip to content

Updated instructions for installing rust-analyzer under Gentoo. #15922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

paul-jewell
Copy link
Contributor

No need to install the guru overlay to install rust-analyzer. This is now installed based on use flag settings for dev-lang/rust and dev-lang/rust-bin. This pull request changes the instructions in the user manual.

Note: rust-analyzer is not available in the guru repository, so the old instructions no longer work.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 17, 2023
@lnicola
Copy link
Member

lnicola commented Nov 17, 2023

Thanks. Are you sure those are the same thing? The Rust toolchain also includes rust-analyzer, but it's usually pretty outdated. I would expect dev-util/rust-analyzer-bin to match this repo and dev-lang/rust-bin to match the official toolchain (i.e. what you'd get by using rustup).

@paul-jewell
Copy link
Contributor Author

Thanks Inicola. First of all, please accept my apologies - I was not familiar with the fact that the version of rust-analyzer distributed with rust is older. I am working on setting up the helix editor and it needs rust-analyzer, but the original instructions failed to provide it, hence my pull request. I can't find reference to dev-util/rust-analyzer-bin in the standard gentoo portage repository, or in the guru repository. Do you know if it is available in a different overlay?

@lnicola
Copy link
Member

lnicola commented Nov 17, 2023

The reference is in the paragraph you've deleted, I don't know if it still works.

@paul-jewell
Copy link
Contributor Author

The guru overlay referenced in the original paragraph no longer includes dev-util/rust-analyzer - looking at this comment on their git repo, it was removed when the rust-analyzer flag was implemented on the dev-lang/rust and dev-lang/rust-bin packages: here

I installed the overlay to confirm that it is indeed no longer present. In the absence of a better solution, the instructions in my pull request will at least give gentoo users a working version of rust-analyzer, albeit an older version. The version reported by rust-analyzer is currently is 1.71.1, aligned with the rust compiler. The date on the rust compiler release is 2023-08-03, so I guess the rust-analyzer version comes from around the same period.

@lnicola
Copy link
Member

lnicola commented Nov 18, 2023

so I guess the rust-analyzer version comes from around the same period

rust-analyzer gets synced with downstream once a week, but changes don't get ported to the beta branch. So for example, 1.77 will be released on March 21, gets branched on February 2, so only includes a RA version before that date, which is around January 29.

And that's in the ideal case. At time syncs were suspended for months at a time, usually because of technical issues.

@Veykril
Copy link
Member

Veykril commented Jan 3, 2024

Whats the status of this PR (I haven no clue about gentoo)

@paul-jewell
Copy link
Contributor Author

If you use rust in Gentoo with the system installed tools, following the instructions in my pull request will ensure you have the version of rust-analyzer installed which came with the compiler release. The alternative is to use rustup at a user level, and install rust-analyzer that way - something I didn't document in the pull request. The instructions to use the guru overlay are not valid at present, since rust-analyzer has been removed as a package from that overlay. I recommend merging the pull request, and if you want me to document the rustup approach as well, then let me know and I will make another pull request to implement.

@Veykril
Copy link
Member

Veykril commented Jan 3, 2024

If the guru version was removed than this seems to be better indeed already, adding rustup wouldn't hurt either here though but it doesn't matter too much.
@bors r+

@bors
Copy link
Contributor

bors commented Jan 3, 2024

📌 Commit 331abe2 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jan 3, 2024

⌛ Testing commit 331abe2 with merge 91ffbd7...

@bors
Copy link
Contributor

bors commented Jan 3, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 91ffbd7 to master...

@bors bors merged commit 91ffbd7 into rust-lang:master Jan 3, 2024
@lnicola
Copy link
Member

lnicola commented Jan 3, 2024

@paul-jewell did you end up asking the guru maintainers about this?

I'll file a follow-up PR with my proposed addition in #15922 (comment).

bors added a commit that referenced this pull request Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants