internal: make mir::ProjectionStore-impls pub-accessible #15760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
ChristianSchott
commented
Oct 14, 2023
| @@ -267,13 +267,13 @@ impl ProjectionStore { | |||
| } | |||
|
|
|||
| impl ProjectionId { | |||
| const EMPTY: ProjectionId = ProjectionId(0); | |||
| pub const EMPTY: ProjectionId = ProjectionId(0); | |||
There was a problem hiding this comment.
not 100% sure about this, as it can be accessed indirectly via From<LocalId>..
|
@bors r+ |
|
☀️ Test successful - checks-actions |
lnicola
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using RA as a crate the
mir::Placeprojectionis accessible, however there is no way to translate theProjectionIdto a&[PlaceElem], as theProjectionId::lookupis private.Personally, I would only need the
ProjectionId::lookup-fn to bepub, but I don't see any reason why the others should be kept private.. am I missing something @HKalbasi ?Relates to: #15575