Skip to content

fix: Fix proc-macro slow test #14995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Jun 7, 2023

No description provided.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 7, 2023
@Veykril Veykril mentioned this pull request Jun 7, 2023
@Veykril
Copy link
Member Author

Veykril commented Jun 7, 2023

@bors R+

@lnicola
Copy link
Member

lnicola commented Jun 7, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Jun 7, 2023

📌 Commit a6bef78 has been approved by lnicola

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jun 7, 2023

⌛ Testing commit a6bef78 with merge 1c25885...

@@ -916,7 +927,7 @@ pub fn foo(_input: TokenStream) -> TokenStream {
},
"procMacro": {
"enable": true,
"server": PathBuf::from(env!("CARGO_BIN_EXE_rust-analyzer")),
Copy link
Member

@lnicola lnicola Jun 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, noticed this recently and was wondering how it could work..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm more surprised that I didn't test this locally when I removed that rust-analyzer command 😰 I could swear I did, though maybe I didn't set the env var for slowt tests correctly

@bors
Copy link
Contributor

bors commented Jun 7, 2023

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 1c25885 to master...

@bors bors merged commit 1c25885 into rust-lang:master Jun 7, 2023
@Veykril Veykril deleted the proc-macro-slow-test branch June 7, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants