internal: Make tt generic over the span data #14061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
bors
added a commit
that referenced
this pull request
Jan 31, 2023
feat: Remove support for 1.58 proc-macro abi This seems old enough that we can drop the support for it now, the less ABIs we have the less work it is adjusting our span implementation. Extracted from #14061, will rebase that over this once merged.
|
I just realized, changing our span data will probably break proc-macros in general again, since we are changing the amount of data that is exchanged (this PR doesn't do that yet) 😬 I guess after this I'll first look into versioning the |
|
@bors r+ |
bors
added a commit
that referenced
this pull request
Jan 31, 2023
Make tt generic over the span data This also fixes up our delimiter representation in tt, it is no longer optional (we use invisible delims in the same way as before, that is still incorrectly) and we now store two spans instead of one. These changes should help with adjusting our token map. Though this will probably break proc-macros in some ways, will need to test that for now.
|
💔 Test failed - checks-actions |
|
@bors retry |
|
☀️ Test successful - checks-actions |
lnicola
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes up our delimiter representation in tt, it is no longer optional (we use invisible delims in the same way as before, that is still incorrectly) and we now store two spans instead of one.
These changes should help with adjusting our token map. Though this will probably break proc-macros in some ways, will need to test that for now.