Skip to content

Improve goto declaration #13671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 25, 2022
Merged

Improve goto declaration #13671

merged 2 commits into from
Nov 25, 2022

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Nov 24, 2022

Closes #13599

  • goto decl now goes to assoc items of trait declarations over the items of trait implementations
  • goto decl now goes to the field declaration (opposed to goto def which shows both the field decl and binding created/local being used)
  • also adds back the goto definition fallback that seems to have been dropped at some point.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 24, 2022
@Veykril
Copy link
Member Author

Veykril commented Nov 25, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Nov 25, 2022

📌 Commit ae0bdff has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Nov 25, 2022

⌛ Testing commit ae0bdff with merge 99daf23...

@bors
Copy link
Contributor

bors commented Nov 25, 2022

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 99daf23 to master...

@bors bors merged commit 99daf23 into rust-lang:master Nov 25, 2022
@Veykril Veykril deleted the goto-decl branch January 27, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Goto declaration on assoc items of trait implementation should go to the assoc item of the trait
3 participants
@Veykril @bors @rustbot