feat: adds hover hint to ".." in record pattern

[kartva]

Hovering on the "rest" pattern in struct destructuring,

struct Baz {
    a: u32,
    b: u32,
    c: u32,
    d: u32
}

let Baz { a, b, ..$0} = Baz { a: 1, b: 2, c: 3, d: 4 };

shows:

.., c: u32, d: u32

Currently only works with struct patterns.

[kartva]

Huh, this is weird. Now, the Run Extension (Debug Build) (rust-analyzer) VSCode action launches a window which shows the following error:

Cannot activate rust-analyzer extension: Language client is not ready yet when handling experimental/serverStatus

And then trying to start r-a gives this error:

_a.isRunning is not a function

And sometimes

command 'rust-analyzer.startServer' not found

The weirdest thing is that I stashed my changes and retried, but it still isn't working. Did a recent VSCode update break stuff?

[Veykril]

You might need to update your vscode, we recently bumped the minimum version i think

[kartva]

Even weirder: I'm using the latest version (v1.73.1)

[kartva]

@rustbot label -S-waiting-on-author +S-waiting-on-review

[Veykril]

Would be good to add a test or two

[Veykril]

The [] should stay here

[kartva]

I'll do that, but is there any reasoning that I'm missing? Which syntax is image::? I don't think it's a Markdown thing.

[Veykril]

It's Asciidoc

[kartva]

Is there a reason that the hover.rs file is separate from the hover folder which contains the test and render modules? Wouldn't it be better to have it moved as hover/mod.rs?

[kartva]

@rustbot label -S-waiting-on-author +S-waiting-on-review

[Veykril]

hover/mod.rs is the old style of modules, we prefer using the new one.

[Veykril]

Thanks!
@bors r+

[bors]

📌 Commit a26aef9 has been approved by Veykril

It is now in the queue for this repository.

[bors]

⌛ Testing commit a26aef9 with merge 6918009...

[bors]

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 6918009 to master...