Skip to content

Bump chalk #13408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2022
Merged

Bump chalk #13408

merged 1 commit into from
Oct 16, 2022

Conversation

lowr
Copy link
Contributor

@lowr lowr commented Oct 13, 2022

There's a bug in current chalk that prevents us from properly supporting GATs, which is supposed to be fixed in v0.86. Note the following:

Two breaking changes from v0.84:

@lowr
Copy link
Contributor Author

lowr commented Oct 13, 2022

CI failed successfully 😎

@bjorn3 bjorn3 added the A-ty type system / type inference / traits / method resolution label Oct 13, 2022
@lnicola
Copy link
Member

lnicola commented Oct 13, 2022

Just wait for #13401 😄

Two breaking changes:
- `TypeFolder` has been split into `TypeFolder` and `FallibleTypeFolder`
- `ProjectionTy::self_type_parameter()` has been removed
@lowr lowr force-pushed the patch/bump-chalk-0.86 branch from a039b4f to 310a72b Compare October 16, 2022 10:25
@lowr lowr marked this pull request as ready for review October 16, 2022 10:46
@Veykril
Copy link
Member

Veykril commented Oct 16, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Oct 16, 2022

📌 Commit 310a72b has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 16, 2022

⌛ Testing commit 310a72b with merge 4876693...

@bors
Copy link
Contributor

bors commented Oct 16, 2022

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 4876693 to master...

@bors bors merged commit 4876693 into rust-lang:master Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ty type system / type inference / traits / method resolution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants