fix overflow during type inference for tuple struct patterns #12409
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following code causes integer overflow during type inference for (malformed) tuple struct patterns.
It has been panicking only in debug builds, and working in a way in release builds but it was inconsistent with type inference for tuple patterns:
With this PR, the overflow no longer happens by utilizing
saturating_sub()
like in other places and type inference for tuple struct patterns is in line with that for tuple patterns.