Skip to content

feat: Lower values of char and byte literals #12157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2022

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented May 5, 2022

Closes #12137

@lnicola lnicola force-pushed the lower-char-byte-literals branch from 85d7fb0 to 9856144 Compare May 5, 2022 05:12
@lnicola
Copy link
Member Author

lnicola commented May 5, 2022

As expected, this doesn't affect the memory usage:

# baseline
Database loaded:     609.77ms, 244minstr, 100mb (metadata 416.03ms, 24minstr, 500kb; build 110.58ms, 8807kinstr, 40kb)
  crates: 39, mods: 878, decls: 20841, fns: 15585
Item Collection:     9.90s, 80ginstr, 375mb
  exprs: 427870, ??ty: 325 (0%), ?ty: 123 (0%), !ty: 1                                                                                                             
Inference:           52.23s, 386ginstr, 729mb
Total:               62.12s, 466ginstr, 1104mb

# pr
Database loaded:     619.90ms, 245minstr, 100mb (metadata 413.23ms, 24minstr, 500kb; build 113.97ms, 8766kinstr, 40kb)
  crates: 39, mods: 878, decls: 20841, fns: 15585
Item Collection:     10.09s, 80ginstr, 375mb
  exprs: 427870, ??ty: 325 (0%), ?ty: 123 (0%), !ty: 1                                                                                                             
Inference:           50.78s, 375ginstr, 729mb
Total:               60.87s, 455ginstr, 1104mb

@lnicola
Copy link
Member Author

lnicola commented May 5, 2022

image

@Veykril
Copy link
Member

Veykril commented May 5, 2022

@bors r+

@bors
Copy link
Contributor

bors commented May 5, 2022

📌 Commit 9856144 has been approved by Veykril

@bors
Copy link
Contributor

bors commented May 5, 2022

⌛ Testing commit 9856144 with merge e789d73...

@bors
Copy link
Contributor

bors commented May 5, 2022

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing e789d73 to master...

@bors bors merged commit e789d73 into rust-lang:master May 5, 2022
@lnicola lnicola deleted the lower-char-byte-literals branch May 5, 2022 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Hover hint for a byte const reports 0 rather than its value
3 participants