fix: Improve parameter completion #12040
Conversation
| fn g(foo: (), mut ba$0: u32) | ||
| fn f(foo: (), mut bar: u32) {} |
There was a problem hiding this comment.
Only when editor's insert mode set to replace? Is there a way to test edit results with lsp cap and editor settings? Not seems possible with CompletionConfig yet
| fn f(foo: (), #[baz = "qux"] mut bar: u32) {} | ||
| fn g(foo: (), mut ba$0) |
There was a problem hiding this comment.
Tests pass for both completion listing and edit, but doesn't work on my machine, not sure what's wrong.
There was a problem hiding this comment.
This might be the same bug that I fixed in #11967 - basically, the completion's lookup_by must start with the characters in its range, otherwise the editor will filter out the completion
There was a problem hiding this comment.
If I understand correctly, 8f8f20f should fix this? At least it became working in my environment.
|
Works great for me, thanks! @bors r+ |
|
📌 Commit 8f8f20f has been approved by |
|
☀️ Test successful - checks-actions |
fix #12016 and handles some extra cases.