Skip to content

feat: Implement inline callers assist #10352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 26, 2021
Merged

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Sep 25, 2021

Fixes #7242

@Veykril Veykril marked this pull request as ready for review September 26, 2021 14:02
@Veykril
Copy link
Member Author

Veykril commented Sep 26, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 26, 2021

@bors bors bot merged commit cd7b26c into rust-lang:master Sep 26, 2021
@Veykril Veykril deleted the inline-callers branch September 26, 2021 14:13
@lnicola
Copy link
Member

lnicola commented Sep 26, 2021

inline-into-callers

@Veykril
Copy link
Member Author

Veykril commented Sep 26, 2021

Looks like we need to special case if we inline in the left side of a binary expression by wrapping in the block in parentheses 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inline function into all callers
2 participants