Skip to content

internal: Use ManuallyDrop in RootDatabase to improve build times #10069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2021
Merged

internal: Use ManuallyDrop in RootDatabase to improve build times #10069

merged 1 commit into from
Aug 28, 2021

Conversation

jonas-schievink
Copy link
Contributor

@jonas-schievink jonas-schievink commented Aug 28, 2021

Closes #10065

@matklad
Copy link
Member

matklad commented Aug 28, 2021

release compile time go 65s -> 55s for me. That's a huuuge win, kudos!

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 28, 2021

@bors bors bot merged commit 7e31c5e into rust-lang:master Aug 28, 2021
@jonas-schievink jonas-schievink deleted the manually-drop-rootdb branch August 28, 2021 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Who drops all the Arcs ?
2 participants