Extension fails to start on latest nightly

[bjorn3]

The developer tools of vs code show the following:

console.ts:137 [Extension Host] /bin/sh: regel 1: rustc: opdracht niet gevonden
C @ console.ts:137
mainThreadExtensionService.ts:107 Activating extension 'rust-lang.rust-analyzer' failed: Command failed: rustc -V -v
/bin/sh: regel 1: rustc: opdracht niet gevonden

where "opdracht niet gevonden" is Dutch for "command not found".

It works fine with the latest stable version of the extension.

I suspect that #18281 caused this regression. cc @darichey

[bjorn3]

By the way I'm running vscode inside flatpak, but rust-analyzer automatically gets spawned outside of it by vscode afaik.

[darichey]

I agree #18281 could be related, but it's unclear how: the only commands it should affect are rustup and rust-analyzer --version.

FWIW, I can't repro. I also can't find where rust-analyzer is trying to run that command during activation.
edit: I didn't realize this was in a top level definition, this is it:

rust-analyzer/editors/code/src/debug.ts

Line 243 in 8dd53a3

execSync("rustc -V -v", {}).toString(),

[davidbarsky]

#18265 seems a little suspicious to me, especially since it's a regex + exec and it calls rustc. We should probably fix and/or revert that PR.

[davidbarsky]

I'll put up a PR with a fix, one moment.

[Veykril]

Oh my bad, I somehow overlooked that odd call there.

[davidbarsky]

No worries, I'm just doing a slight refactor right now to consolidate where the symbol map is populated.

[davidbarsky]

Opened #18320.