Skip to content

Misleading command name > rust-analyzer: Expand macro recursively #15856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
loynoir opened this issue Nov 9, 2023 · 4 comments · Fixed by #15870
Closed

Misleading command name > rust-analyzer: Expand macro recursively #15856

loynoir opened this issue Nov 9, 2023 · 4 comments · Fixed by #15870
Labels
A-vscode vscode plugin issues C-enhancement Category: enhancement E-easy

Comments

@loynoir
Copy link

loynoir commented Nov 9, 2023

actual

As far as I found,

  • The command name is misleading > rust-analyzer: Expand macro recursively

I understand it as expand full file.

expected

  • command name > rust-analyzer: Expand macro recursively at cursor
@loynoir loynoir added the C-bug Category: bug label Nov 9, 2023
@lnicola
Copy link
Member

lnicola commented Nov 9, 2023

Expanding the full file would be called Expand macros recursively.

@Veykril
Copy link
Member

Veykril commented Nov 10, 2023

This command doesnt expand all macros in the current file, but only the one under the cursor (recursively), so this is labeled correctly

@Veykril Veykril closed this as completed Nov 10, 2023
@loynoir
Copy link
Author

loynoir commented Nov 10, 2023

I know.

I suggest, add two words at cursor to command display name.

Zero ambiguity.

@Veykril
Copy link
Member

Veykril commented Nov 11, 2023

Fair, I agree we can change it to Expand macro at cursor recursively that seems like an improvement.

@Veykril Veykril reopened this Nov 11, 2023
@Veykril Veykril added E-easy A-vscode vscode plugin issues C-enhancement Category: enhancement and removed C-bug Category: bug labels Nov 11, 2023
bors added a commit that referenced this issue Nov 12, 2023
minor: Make "Expand macro" command title more explicit

Closes [#15856](#15856).

I opted for "caret", since it's the better term (cursor is the mouse), but I'm not sure how popular it is these days.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-vscode vscode plugin issues C-enhancement Category: enhancement E-easy
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants