-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Trait item completions could work better #11860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
A-completion
autocompletion
C-bug
Category: bug
S-actionable
Someone could pick this issue up and work on it right now
Comments
That's probably #11467 |
bors bot
added a commit
that referenced
this issue
Apr 8, 2022
11938: feat: improve assoc. item completion in trait impls r=jonas-schievink a=jonas-schievink Account for macro-generated items, increase the score of these completions since they're very relevant, and allow them to trigger when the cursor is directly in the assoc. item list without requiring further input.  Part of #11860 bors r+ Co-authored-by: Jonas Schievink <[email protected]>
bors bot
added a commit
that referenced
this issue
Apr 8, 2022
11938: feat: improve assoc. item completion in trait impls r=jonas-schievink a=jonas-schievink Account for macro-generated items, increase the score of these completions since they're very relevant, and allow them to trigger when the cursor is directly in the assoc. item list without requiring further input.  Part of #11860 bors r+ Co-authored-by: Jonas Schievink <[email protected]>
bors bot
added a commit
that referenced
this issue
Apr 12, 2022
11967: fix: Fix trait impl completions not triggering after `fn`/`const`/`type` r=jonas-schievink a=jonas-schievink  Fixes #11467 cc #11860 bors r+ Co-authored-by: Jonas Schievink <[email protected]>
bors bot
added a commit
that referenced
this issue
Apr 12, 2022
11967: fix: Fix trait impl completions not triggering after `fn`/`const`/`type` r=jonas-schievink a=jonas-schievink  Fixes #11467 cc #11860 bors r+ Co-authored-by: Jonas Schievink <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-completion
autocompletion
C-bug
Category: bug
S-actionable
Someone could pick this issue up and work on it right now
Uh oh!
There was an error while loading. Please reload this page.
Given this code:
The completion we provide are generally pretty bad:
$0
without typing anything else just shows generic completions. We should prioritize completions of missing trait items to be at the very top there.$0
withfn
and then requesting completions shows nothing. Instead, bothrequired
andprovided
should show up.Ty
andKONST
does not complete the required;
at the end, but thefn
completions do include the function body and place the cursor inside.The text was updated successfully, but these errors were encountered: