Statics may sometimes inline. #323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alercah
approved these changes
May 1, 2018
| Static items may be placed in read-only memory if the type is not [interior | ||
| mutable]. Static items do not call `drop` at the end of the program. | ||
| memory location in the program. All references to the static refer to the same | ||
| memory location. Static items have the `static` lifetime, which outlives all |
There was a problem hiding this comment.
Should this be 'static lifetime instead?
There was a problem hiding this comment.
'static is the static lifetime. I think both could work there.
| @@ -6,18 +6,17 @@ | |||
| > `=` [_Expression_] `;` | |||
|
|
|||
| A *static item* is similar to a [constant], except that it represents a precise | |||
There was a problem hiding this comment.
This paragraph is just a list of properties, which makes me feel like it does not flow very well. I'm not sure the best way to address that; perhaps splitting the things about lifetimes into a separate paragraph would help, or adding more connective prose?
There was a problem hiding this comment.
It definitely doesn't flow well. It reads almost like a list but without the bullet points. Should probably be addressed, but not as part of this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed inlining guarantees as they are false e.g. in the case of using a non-mutable static integer. Added "Non-
mut" to the statement about read-only memory. Removed the parenthesis about bindingCstatics. Added a link to destructors where it says "drop".