Grammar for expressions #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewjasper
approved these changes
Mar 10, 2018
There was a problem hiding this comment.
Looks good.
Also, there must be a ExpressionNoStructLiteral and a ExpressionStmtExpr that other productions use, but I'm still trying to find a good way to show this without cluttering the grammar.
Raised as #266
Havvy
approved these changes
Mar 11, 2018
There was a problem hiding this comment.
I cross-checked the list with the table of contents. This was harder than it seemed because this list is out of sync with the table of contents. IMO, they should be in sync. So are you proposing this is a better list than the table of contents currently is? Or do you have a different reason for this specific ordering?
|
I don't quite remember why I chose this order or if there was any thinking involved. I will change them to match the TOC. |
|
💟 😍 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please notice that the link to the GroupedExpression is technically broken, but the PR #261 corrects it.
Also, there must be a ExpressionNoStructLiteral and a ExpressionStmtExpr that other productions use, but I'm still trying to find a good way to show this without cluttering the grammar.