Implement `mach_timebase_info` for macOS #1331

samrat · 2020-04-13T15:50:19Z

Since we return nanoseceonds instead of ticks from mach_absolute_time, we don't need to scale the absolute time

Since we return nanoseceonds instead of ticks from `mach_absolute_time`, we don't need to scale the absolute time

samrat · 2020-04-13T15:53:41Z

@RalfJung Please let me know if you think the approach of always returning returning 1 for both numer and denom so as not to scale the value returned by mach_absolute_time is not the right way to go about this.

RalfJung · 2020-04-13T17:22:44Z

Please let me know if you think the approach of always returning returning 1 for both numer and denom so as not to scale the value returned by mach_absolute_time is not the right way to go about this.

That is exactly the right way, yes. Indeed that's why I picked nanoseconds, I just was too lazy to also implement mach_timebase_info... and I figured this would make a great first PR for someone, so welcome. :D

src/shims/time.rs

tests/run-pass/time.rs

RalfJung · 2020-04-13T17:28:11Z

This looks great overall, I just have a few nits. :)

src/shims/time.rs

Also fix typo and remove newline

src/shims/time.rs

And add comment documenting successful return value from `mach_timebase_info`.

src/shims/time.rs

Co-Authored-By: Ralf Jung <[email protected]>

RalfJung · 2020-04-14T08:41:05Z

Awesome, thanks a lot. :D
@bors r+

bors · 2020-04-14T08:41:06Z

📌 Commit fff45b7 has been approved by RalfJung

bors · 2020-04-14T09:30:27Z

⌛ Testing commit fff45b7 with merge 669191b...

bors · 2020-04-14T10:52:33Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: RalfJung
Pushing 669191b to master...

[macOS] Implement mach_timebase_info

5f6d250

Since we return nanoseceonds instead of ticks from `mach_absolute_time`, we don't need to scale the absolute time

RalfJung reviewed Apr 13, 2020

View reviewed changes