add benchmark functions #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is failing because of using nightly test feature (for bench functionality). Should we allow this or should we use something else, maybe criterion? Or is there another way? |
|
To avoid this problem, create a new |
rust-cloud-vms
bot
force-pushed
the
add-benches
branch
from
2b0fd41 to
25c2cbe
Compare
GuillaumeGomez
approved these changes
May 27, 2025
|
This is great, thanks a lot! Now summoning someone who can actually merge. XD cc @Urgau |
Urgau
approved these changes
May 27, 2025
|
Looks fine to me, but didn't do a deep dive into all the benches, I trust @GuillaumeGomez did it. One tough: it would be good to check those benches in CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.