This repository was archived by the owner on Apr 28, 2025. It is now read-only.
Fix the atan family of functions behavior with bounds checks #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
force-pushed
the
wrapping-atan2
branch
from
c7aa961 to
e949ab9
Compare
|
Again sorry for the very long delay on merging this also still passes tests so merging! |
tgross35
pushed a commit
that referenced
this pull request
Apr 18, 2025
Fix the atan family of functions behavior with bounds checks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to #142, this changes
atan2to use wrapping addition.atan,atanf, andatan2fwere already OK with bounds checks.