Add MADV_SOFT_OFFLINE definition for RISC-V musl targets #4447
+3
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds missing MADV_SOFT_OFFLINE definitions for RISC-V musl targets. It is analogous to #2391 where the same definitions were added for RISC-V glibc targets. The patch addresses a rustix build issue: bytecodealliance/rustix#1462
Sources
https://github.com/bminor/musl/blob/c47ad25ea3b484e10326f933e927c0bc8cded3da/include/sys/mman.h#L99
Checklist
libc-test/semver
have been updated-- I have added MADV_SOFT_OFFLINE to libc-test/semver/linux-riscv64gc.txt for good measure
*LAST
or*MAX
areincluded (see rust-lang/libc#3131)
cd libc-test && cargo test --target riscv64gc-unknown-linux-{gnu,musl}
);especially relevant for platforms that may not be checked in CI
-- I've tested the
riscv64gc-unknown-linux-musl
target against a riscv-gnu-toolchain musl build - there are actually a bunch of other issues with struct layout, field name, and value inconsistencies, but these are unrelated to my change.@rustbot label +stable-nominated