-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add the TIOCGWINSZ and TIOCSWINSZ constants #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Add the TIOCGWINSZ and TIOCSWINSZ constants I've added the `TIOCGWINSZ` and `TIOCSWINSZ` constants/ioctl control codes. I wasn't quite sure where to put them, so hopefully they're in the right place. As of now it's set to compile on 'FreeBSD-like' platforms, so it will compile on both FreeBSD *and* DragonflyBSD. I've only tested it on FreeBSD though, but it should also work on DragonflyBSD AFAIK. Fixes #292.
💔 Test failed - travis |
Seems like the build failure was caused by an error connecting to a server, not my code. |
@bors: retry Indeed! |
Add the TIOCGWINSZ and TIOCSWINSZ constants I've added the `TIOCGWINSZ` and `TIOCSWINSZ` constants/ioctl control codes. I wasn't quite sure where to put them, so hopefully they're in the right place. As of now it's set to compile on 'FreeBSD-like' platforms, so it will compile on both FreeBSD *and* DragonflyBSD. I've only tested it on FreeBSD though, but it should also work on DragonflyBSD AFAIK. Fixes #292.
☀️ Test successful - status-appveyor, travis |
🎉 |
Add gettid I tested this under linux, and I noticed that this seems to also be built for OSX. It would be appreciated if someone could test this under OSX. I'm not familiar enough with rust to know if there is a way of integrating this without creating a sub-crate.
I believe we're reserving the `simd` module for exclusively the portable types and their operations, so this commit moves the various x86-specific types from the portable modules to the `x86` module. Along the way this also adds some doc blocks for all the existing x86 types.
I've added the
TIOCGWINSZ
andTIOCSWINSZ
constants/ioctl control codes. I wasn't quite sure where to put them, so hopefully they're in the right place.As of now it's set to compile on 'FreeBSD-like' platforms, so it will compile on both FreeBSD and DragonflyBSD. I've only tested it on FreeBSD though, but it should also work on DragonflyBSD AFAIK.
Fixes #292.