Add memfd_create to linux and android #2069
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
I'm personally in favor of just exposing everything and letting the user deal with linker errors if their toolchain is too old. The only limitation is whether our CI accepts it. |
|
@bors r+ |
|
📌 Commit 429cef2 has been approved by |
Add memfd_create to linux and android Android only added the wrapper in API level 30, i.e. Android 11. Should this have libc::syscall implementation for android ?
|
💔 Test failed - checks-actions |
|
Maybe try upgrading the Android NDK in the CI scripts? |
|
@bors r+ |
|
📌 Commit da1fc9c has been approved by |
Add memfd_create to linux and android Android only added the wrapper in API level 30, i.e. Android 11. Should this have libc::syscall implementation for android ?
|
💔 Test failed - checks-actions |
|
@bors r+ |
|
@jwellhofer: 🔑 Insufficient privileges: Not in reviewers |
|
@bors r+ |
|
📌 Commit 5920c8d has been approved by |
Add memfd_create to linux and android Android only added the wrapper in API level 30, i.e. Android 11. Should this have libc::syscall implementation for android ?
|
💔 Test failed - checks-actions |
jwellhofer
force-pushed
the
master
branch
3 times, most recently
from
8b1adff to
5265cde
Compare
|
I tried to figure out the CI and get it to use Android API level 30, but couldn't figure out how to fiddle linker/linker64 out of the new sdk emulator image. |
|
I'm not sure how I feel about this. Traditionally libc only contains bindings to existing functions rather than actual implementations. Maybe just drop the Android part for now? Or is Android support something that you actually need? |
|
I've found a way to get the newer android binaries, but it'll take me a while to figure out how to update the CI. Once i've got the CI working, i'll make a PR for that. I'll come back here when that is done. |
|
☔ The latest upstream changes (presumably #2079) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Could we proceed with just the Linux version in the mean time? e.g. tokio-rs/tracing#1698 calls for it. |
|
Updating the android CI was such a pain that i gave up and just used a patched rust-libc. |
|
@bors r+ |
|
📌 Commit f1bd231 has been approved by |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13 |
|
Thanks! |
Android only added the wrapper in API level 30, i.e. Android 11. Should this have libc::syscall implementation for android ?