-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add DevkitPPC support #1851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DevkitPPC support #1851
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Looks good, let's re-run CI... |
It seems |
I added another commit to gate the cfg checks behind a feature as well. It appears to work for a ppc linux target with version 1.13.0 |
I think this would be better: JohnTitor@70e1129 |
it doesn't appear to do that, probably because i'm only using one layer of conditionals inside the cfg
|
The changes look good to me. Does this work fine on your environment? If so, r=me once the commits are squashed. |
DevkitPPC does not support unix sockets natively, meaning that bindings to these functions was removed for powerpc targets with "nintendo" as vendor. Suggested target json files: Nintendo Gamecube: ``` { "arch": "powerpc", "data-layout": "E-m:e-p:32:32-i64:64-n32", "dynamic-linking": false, "env": "newlib", "executables": true, "has-elf-tls": false, "has-rpath": true, "linker-flavor": "gcc", "llvm-target": "powerpc-eabi", "max-atomic-width": 32, "os": "dolphin", "target-c-int-width": "32", "target-endian": "big", "target-family": "unix", "target-mcount": "_mcount", "target-pointer-width": "32", "vendor": "nintendo" } ``` Nintendo Wii: ``` { "arch": "powerpc", "data-layout": "E-m:e-p:32:32-i64:64-n32", "dynamic-linking": false, "env": "newlib", "executables": true, "has-elf-tls": false, "has-rpath": true, "linker-flavor": "gcc", "llvm-target": "powerpc-eabi", "max-atomic-width": 32, "os": "revolution", "target-c-int-width": "32", "target-endian": "big", "target-family": "unix", "target-mcount": "_mcount", "target-pointer-width": "32", "vendor": "nintendo" } ```
works fine on my end |
Hmm, it seems spurious:
Re-triggering CI... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, finally it's green. Thanks for contributing!
DevkitPPC is the de-facto Homebrew development kit for the Nintendo Gamecube, Wii and Wii U consoles. It is based on a gcc+binutils+newlib toolchain.
This pull request adds initial support for these 3 consoles.
DevkitPPC does not support unix-style sockets natively, meaning that bindings
to these functions was removed for powerpc targets with "nintendo" as
vendor
Suggested target json files:
Nintendo Gamecube:
Nintendo Wii: