Skip to content

type change for AF_INET, PF_INET AF_INET6 PF_INET6 #1794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

sum12
Copy link

@sum12 sum12 commented Jun 23, 2020

I am not sure if this change is enough or more is needed fo #468

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@bors
Copy link
Contributor

bors commented Jun 23, 2020

☔ The latest upstream changes (presumably #1793) made this pull request unmergeable. Please resolve the merge conflicts.

@JohnTitor
Copy link
Member

Hey, thanks for the PR! But this is a breaking change, as Alex said, and I'd hold off this as we currently have no plan to make a release 0.3 or 1.0.

@sum12
Copy link
Author

sum12 commented Jun 26, 2020

ok. Thanks for taking a look.
Any other ways I could contribute ?

@JohnTitor
Copy link
Member

Any other ways I could contribute ?

Basically we add items when we need them. There're some requests on the issue tracker that someone wants to use constants or functions, I think they're good stuff to contribute (btw, if you want to contribute to Rust, there're some repos like rust-lang/rust that have more newcomer welcome issues).

@bors
Copy link
Contributor

bors commented Oct 29, 2020

☔ The latest upstream changes (presumably #1962) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@joshtriplett
Copy link
Member

Even if we were making breaking changes, I don't think we'd want to change the types of these particular constants and not others in the same category.

In C, these are preprocessor symbols, and they don't have a type. I don't think this kind of change is worth the breakage it would cause.

@safinaskar
Copy link

Now this can be resent to libc 0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants