Skip to content

Add pthread_main_np to FreeBSD-like and _lwp_self to NetBSD #1533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2019

Conversation

murarth
Copy link
Contributor

@murarth murarth commented Sep 28, 2019

No description provided.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@gnzlbg
Copy link
Contributor

gnzlbg commented Sep 28, 2019 via email

@bors
Copy link
Contributor

bors commented Sep 28, 2019

📌 Commit 36a92d5 has been approved by asomers

@bors
Copy link
Contributor

bors commented Sep 28, 2019

⌛ Testing commit 36a92d5 with merge ff63cb5...

bors added a commit that referenced this pull request Sep 28, 2019
Add `pthread_main_np` to FreeBSD-like and `_lwp_self` to NetBSD
@bors
Copy link
Contributor

bors commented Sep 28, 2019

☀️ Test successful - checks-cirrus-freebsd-10, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure
Approved by: asomers
Pushing ff63cb5 to master...

@bors bors merged commit 36a92d5 into rust-lang:master Sep 28, 2019
@murarth murarth deleted the bsd-pthread-main-np branch September 28, 2019 15:38
@asomers
Copy link
Contributor

asomers commented Sep 28, 2019

Not that there's anything wrong with this PR, but why did you tell bors that I approved it?

@gnzlbg
Copy link
Contributor

gnzlbg commented Sep 30, 2019

I'm on holidays and I screwed it up. I wanted to delegate approving this PR to you so that you could approve it and tell bors to merge it, but instead of delegate=X I wrote r=X and apparently r=X is valid syntax that approves a PR in the name of somebody else =/ Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants