Add F_SEAL_FUTURE_WRITE on Linux/Android #1372
Conversation
|
r? @gnzlbg (rust_highfive has picked a reviewer for you, use r? to override) |
tklauser
force-pushed
the
f-seal-future-write
branch
2 times, most recently
from
1bddccf to
b5b9ef5
Compare
|
Thank you for the PR. This LGTM. I prefer to merge this after #1365 lands, so after that's merged this will need to be rebased on top of it. |
src/unix/notbsd/mod.rs
Outdated
| @@ -465,6 +465,7 @@ pub const F_SEAL_SEAL: ::c_int = 0x0001; | |||
| pub const F_SEAL_SHRINK: ::c_int = 0x0002; | |||
| pub const F_SEAL_GROW: ::c_int = 0x0004; | |||
| pub const F_SEAL_WRITE: ::c_int = 0x0008; | |||
| pub const F_SEAL_FUTURE_WRITE: ::c_int = 0x0010; | |||
There was a problem hiding this comment.
Is this available in emscripten ?
There was a problem hiding this comment.
Not yet, I think. It also seems to be missing from musl currently. What is the proper place to put this in that case? src/unix/notbsd/linux/other/mod.rs and a copy to src/unix/notbsd/android/mod.rs?
There was a problem hiding this comment.
So one copy goes into android/mod.rs, another copy goes into linux/mips/mod.rs/linux/s390x/mod.rs, linux/other/mod.rs - basically everywhere in linux except linux/musl/mod.rs.
|
☔ The latest upstream changes (presumably #1365) made this pull request unmergeable. Please resolve the merge conflicts. |
|
The build.rs has been substantially changed. There is a section in |
tklauser
force-pushed
the
f-seal-future-write
branch
from
b5b9ef5 to
7277138
Compare
|
Thanks @gnzlbg. Now pushed a rebased version and integrated your review comments. |
tklauser
force-pushed
the
f-seal-future-write
branch
from
7277138 to
2458d2a
Compare
|
@bors: r+ |
|
📌 Commit 2458d2a has been approved by |
|
Thank you! |
This was added in Linux 5.1 and will only show up in the next glibc release, thus skip in tests.
tklauser
force-pushed
the
f-seal-future-write
branch
from
2458d2a to
7364369
Compare
|
@bors: r+ |
|
📌 Commit 7364369 has been approved by |
Add F_SEAL_FUTURE_WRITE on Linux/Android This was added in Linux 5.1 and will only show up in the next glibc release, thus skip in tests.
|
☀️ Test successful - checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-travis, status-appveyor |
This was added in Linux 5.1 and will only show up in the next glibc
release, thus skip in tests.