Skip to content

Openbsd fix #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 16, 2018
Merged

Openbsd fix #1040

merged 6 commits into from
Jul 16, 2018

Conversation

semarie
Copy link
Contributor

@semarie semarie commented Jul 14, 2018

put in several fixes for OpenBSD (one fix per commit).
testsuite ran on OpenBSD 6.3-current (upcoming 6.4)

RUNNING ALL TESTS
PASSED 6474 tests

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Jul 14, 2018

📌 Commit fec9baf has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Jul 14, 2018

⌛ Testing commit fec9baf with merge a65a0ba...

bors added a commit that referenced this pull request Jul 14, 2018
Openbsd fix

put in several fixes for OpenBSD (one fix per commit).
testsuite ran on OpenBSD 6.3-current (upcoming 6.4)

```
RUNNING ALL TESTS
PASSED 6474 tests
```
@bors
Copy link
Contributor

bors commented Jul 14, 2018

💔 Test failed - status-travis

@semarie
Copy link
Contributor Author

semarie commented Jul 14, 2018

it is a network failure.

error: component download failed for rust-std-i686-unknown-linux-gnu
info: caused by: could not download file from 'https://static.rust-lang.org/dist/2018-07-10/rust-std-1.27.1-i686-unknown-linux-gnu.tar.xz' to '/home/travis/.rustup/downloads/68f028911a1606e93eb71bdf95fe7d91e2b4cbd247663f3ab1e59d291dcd61b7.partial'
info: caused by: error during download
info: caused by: [18] Transferred a partial file (transfer closed with 47035510 bytes remaining to read)

@semarie
Copy link
Contributor Author

semarie commented Jul 15, 2018

@alexcrichton could you make @bors to retry please ?

@bors
Copy link
Contributor

bors commented Jul 15, 2018

@semarie: 🔑 Insufficient privileges: not in try users

@alexcrichton
Copy link
Member

@bors: retry

bors added a commit that referenced this pull request Jul 16, 2018
Openbsd fix

put in several fixes for OpenBSD (one fix per commit).
testsuite ran on OpenBSD 6.3-current (upcoming 6.4)

```
RUNNING ALL TESTS
PASSED 6474 tests
```
@bors
Copy link
Contributor

bors commented Jul 16, 2018

⌛ Testing commit fec9baf with merge 73c0263...

@bors
Copy link
Contributor

bors commented Jul 16, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 73c0263 to master...

@bors bors merged commit fec9baf into rust-lang:master Jul 16, 2018
@semarie semarie deleted the openbsd-fix branch July 16, 2018 04:10
@gnzlbg
Copy link
Contributor

gnzlbg commented Jul 18, 2018

@semarie is there an easy way to test openbsd in travis-ci ? (e.g. for crates in the nursery?)

@semarie
Copy link
Contributor Author

semarie commented Jul 19, 2018

@gnzlbg I am unsure :-/ The way would be to follow what is done for FreeBSD: crossbuilding the testsuite and run it on QEMU.

I have in my TODO list to work on crossbuilding OpenBSD from Linux for Rust. I think it could be doable now: I recently saw an openbsd developer with ld-gold on OpenBSD (with patches), and we now have a full LLVM on base but we still use your old and customized ld by default. ld.lld is usable. So I except minimal patches on Linux side to have a way to link binaries for OpenBSD. The plumbing still need to be done...

@gnzlbg
Copy link
Contributor

gnzlbg commented Jul 19, 2018

Let me know if you get a "simple" set up going in travis-ci. Ideally we would have a docker Linux image with the cross-compilation toolchain required to cross-compile Rust on Linux for OpenBSD, and then a similar script to the ones used here that uses qemu-system with an OpenBSD image as a test runner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants