Skip to content

Add rollup=iffy, sort by rollup status #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 10, 2020
Merged

Add rollup=iffy, sort by rollup status #94

merged 5 commits into from
Jul 10, 2020

Conversation

Manishearth
Copy link
Member

Fixes #93

@pietroalbini would you be able to do a test deploy?

@Manishearth Manishearth requested a review from pietroalbini July 9, 2020 23:25
@Manishearth Manishearth mentioned this pull request Jul 9, 2020
Closed
pietroalbini
pietroalbini requested changes Jul 10, 2020
View reviewed changes
Copy link
Member

@pietroalbini pietroalbini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Since we're starting to add more rollup states, it might be nice to do a bit of refactoring to make the whole thing more manageable.

@pietroalbini
Copy link
Member

pytest is also failing.

@pietroalbini
Copy link
Member

Hmm, flake8 is also failing. Other than that this looks good to me.

@Manishearth
Copy link
Member Author

Done!

@pietroalbini pietroalbini merged commit ffad7aa into rust-lang:master Jul 10, 2020
@pietroalbini
Copy link
Member

Bumped the homu revision in RCS, will deploy in an hour.

Mark-Simulacrum added a commit to rust-lang/rust-central-station that referenced this pull request Jul 10, 2020
@Mark-Simulacrum
Bump homu
4a5d87a 
* rust-lang/homu#92
* rust-lang/homu#94
* rust-lang/homu#96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pietroalbini pietroalbini pietroalbini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add rollup=iffy
2 participants
@Manishearth @pietroalbini