Skip to content

Commit 829403d

Browse files
committed
Check only (no longer test) at the MSRV
Adjust CI so we only run a check the main crate at the MSRV (1.23), running tests only at the MSRV of test dependencies. This allows us to keep CI passing without increasing `glob`'s MSRV to match that of `libc` (which since recently is 1.63.0) or other test dependencies. Additionally, set `rust-version` in Cargo.toml.
1 parent 03e8d88 commit 829403d

File tree

2 files changed

+18
-2
lines changed

2 files changed

+18
-2
lines changed

.github/workflows/rust.yml

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515
- stable
1616
- beta
1717
- nightly
18-
- 1.23.0
18+
- 1.63.0 # MSRV of test dependencies
1919
os:
2020
- macos-11
2121
- windows-2022
@@ -32,3 +32,18 @@ jobs:
3232
3333
- name: Tests
3434
run: cargo +${{ matrix.channel }} test --all
35+
36+
msrv:
37+
name: Check building with the MSRV
38+
runs-on: ubuntu-22.04
39+
steps:
40+
- name: Checkout repository
41+
uses: actions/checkout@v4
42+
43+
- name: Update rust
44+
run: |
45+
rustup default 1.23.0
46+
rustup update --no-self-update
47+
48+
- name: Tests
49+
run: cargo build

Cargo.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,9 @@ description = """
1111
Support for matching file paths against Unix shell style patterns.
1212
"""
1313
categories = ["filesystem"]
14+
rust-version = "1.23.0"
1415

1516
[dev-dependencies]
16-
# FIXME: Replace it with `tempfile` once we bump up MSRV.
17+
# FIXME: This should be replaced by `tempfile`
1718
tempdir = "0.3"
1819
doc-comment = "0.3"

0 commit comments

Comments
 (0)