Move rustdoc header out of rustdoc container (Fixes #935)

[cynecx]

Closes #935.

[cynecx]

Uh, this is wrong. Nvm.

[jyn514]

For the record:

$ git show HEAD~:templates/rustdoc/body.html | diff - templates/rustdoc/header.html 
238,270d237
< 
< <script type="text/javascript" src="/menu.js?{{ docsrs_version() | slugify }}"></script>
< <script type="text/javascript" src="/index.js?{{ docsrs_version() | slugify }}"></script>
< <script>
<       // Reset the scroll offset on browsers that don't support
<       // scroll-padding-top (Desktop & Mobile Safari):
<       const maybeFixupViewPortPosition = function() {
<         if (window.location.hash) {
<           const anchorElement = document.getElementById(window.location.hash.substr(1));
<           const navBarHeight = document.getElementsByClassName("nav-container-rustdoc")[0].offsetHeight;
<           if (anchorElement &&
<               anchorElement.getBoundingClientRect().top <= navBarHeight &&
<               Math.abs(anchorElement.getBoundingClientRect().top) >= 0) {
<             // It's just overlapped by the nav bar. This can't be a coincidence, scroll it into view:
<             requestAnimationFrame(function() {
<               scrollBy(0, -navBarHeight);
<             });
<           }
<         }
<       };
<       window.addEventListener("hashchange", maybeFixupViewPortPosition, false);
<       // Fix up the scroll position if this was a direct visit to the page
<       // (not back/forward navigation):
<       if (window.performance) {
<         const navEntries = window.performance.getEntriesByType('navigation');
<         const usedBack = navEntries.length > 0 && navEntries[0].type === 'back_forward' ||
<               (window.performance.navigation &&
<                window.performance.navigation.type == window.performance.navigation.TYPE_BACK_FORWARD);
<         if (!usedBack && window.location.hash) {
<           window.addEventListener("scroll", maybeFixupViewPortPosition, {"once": true});
<         }
<       }
< </script>

@cynecx is there a reason you added the extra script?

[cynecx]

@jyn514 Uh. I didn't add anything script related. I've just moved the html from one place to a new template file? Am I missing something?

[jyn514]

Oh I misread the diff - you kept the script in body.html and didn't add it to header.html. Yeah, that seems fine.

[cynecx]

@jyn514 Well, I wasn't sure whether changing the location of the script had any semantic difference, so I've just left it there :)

[jyn514]

Do you mind posting a screenshot of what this looks like after? My styles have been broken for quite some time. You can run the website with cargo run start-web-server on linux or docker-compose up on other platforms.

[jyn514]

🤦 I finally figured out the issue with my styles, I never ran a build with the new styles. Don't worry about getting a screenshot yourself, here's one:

[jyn514]

So this did fix the issue, nice :) looks good to me after nit.

[cynecx]

@jyn514 God damn it. You beat me. I was just running docker-compose xD.

[jyn514]

@jyn514 God damn it. You beat me. I was just running docker-compose xD.

Well, I did already have the full build cached :P