Remove TEMPLATE_DATA static #841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kixiron
approved these changes
Jun 18, 2020
Comment on lines
+116
to
+124
| /// Simple function that returns the pre-defined value. | ||
| struct ReturnValue { | ||
| name: &'static str, | ||
| value: Value, |
pietroalbini
force-pushed
the
remote-template-data-static
branch
from
47c4cef to
2b4091e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
TEMPLATE_DATAstatic from the codebase, switching to a struct stored in the request extensions. This is a requirement for future refactorings. The PR can be reviewed commit-by-commit.r? @Kixiron