Fetch readme from source archive if available for crate details page #2146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
Nemo157
force-pushed
the
source-archive-readme
branch
from
a5e7032 to
e1b278f
Compare
Nemo157
force-pushed
the
source-archive-readme
branch
from
e1b278f to
659b937
Compare
syphar
reviewed
Jun 14, 2023
There was a problem hiding this comment.
awesome improvement! thank you for working on this!
IMO the performance change is small-ish, since
- file-exist queries are executed on the local archive index, so at most 2 S3 requests are executed. ( 3 when we start cleaning local indexes)
- the page is cached in the CDN anyways
I had some small comments & questions.
syphar
added
S-waiting-on-author
A missing readme is ignored, other errors are reported to sentry
Nemo157
added
S-waiting-on-review
syphar
approved these changes
Aug 2, 2023
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1866 and will allow to stop storing the readme in the database for new builds