Skip to content

Allow to click on the footer again by positioning the footer on top of the main div #1603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2022

Conversation

GuillaumeGomez
Copy link
Member

Fixes #1599.

It'd be nice to start having GUI tests for docs.rs like rustdoc (with the same or a different GUI test framework, doesn't matter).

@syphar syphar added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Jan 16, 2022
Copy link
Member

@syphar syphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Testing I saw this issue here, now text seems to be behind the footer and I cannot reach it?

@syphar syphar added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Jan 16, 2022
@Nemo157
Copy link
Member

Nemo157 commented Jan 16, 2022

I don't get that issue testing on my server, the footer is against the bottom of the screen still on both variants of the rustdoc-css.

@syphar
Copy link
Member

syphar commented Jan 16, 2022

strange ... now I cannot reproduce it any more. All seems fine now.

@syphar syphar merged commit 23a717d into rust-lang:master Jan 16, 2022
@syphar syphar added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Jan 16, 2022
@GuillaumeGomez GuillaumeGomez deleted the footer-ontop branch January 16, 2022 18:41
@GuillaumeGomez
Copy link
Member Author

@syphar Strange! If you find the problem again, please remember the page. ;)

@syphar
Copy link
Member

syphar commented Jan 16, 2022

will do so.

@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Footer links not clickable
3 participants