set default target to linux for tests so we can run the tests on non-linux machines #1261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the "default target" should be specified in |
Nemo157
approved these changes
Jan 23, 2021
syphar
changed the title
syphar
force-pushed
the
linux-default-target-tests
branch
from
51c9983 to
901726c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found out that df48965 broke the tests in
web/rustdocfor me, since it changes from a hard-coded linux default-target to usingdocsrs_metadata::HOST_TARGET, which isx86_64-apple-darwinon my machine.Some test-cases ( for example
web::rustdoc::test::default_target_redirects_to_base) rely on the default-target of the fake-release being linux.This PR reverts that part of df48965 so the tests are fine again.