Skip to content

Add favicon to essential files #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Add favicon to essential files #1109

merged 1 commit into from
Oct 22, 2020

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Oct 22, 2020

This can be tested with cargo run build add-essential-files && cargo build chrono 0.4.18.

Closes #1070.

r? @Nemo157

This can be tested with `cargo run build add-essential-files && cargo
build chrono 0.4.18`.
@Nemo157
Copy link
Member

Nemo157 commented Oct 22, 2020

So when I was working on the static files I realised that the per-version favicon.ico is redirected to our favicon.ico, should we do the same and add a static favicon.svg that we redirect to?

@jyn514 jyn514 added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Oct 22, 2020
@jyn514
Copy link
Member Author

jyn514 commented Oct 22, 2020

From our conversation on discord:

  • The complexity of special-casing the favicon doesn't seem worth the benefit (~100 copies of the favicon is trivial compared to the rest of our costs)
  • Storing a single static favicon would miss changes in new versions and we'd have to update manually.

It might be nice long term to look into de-duplicating files in general, which I imagine would have enormous storage cost reductions, but sounds hard to do.

@jyn514 jyn514 merged commit 0e83b5d into rust-lang:master Oct 22, 2020
@jyn514 jyn514 deleted the favicon branch October 22, 2020 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 for favicon on recent docs
2 participants