Skip to content

Strongly type CrateDetails #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Kixiron opened this issue Jul 7, 2020 · 0 comments
Open

Strongly type CrateDetails #886

Kixiron opened this issue Jul 7, 2020 · 0 comments
Labels
A-backend Area: Webserver backend C-technical-debt Category: This makes the code harder to read and modify, but has no impact on end users E-easy Effort: Should be easy to implement and would make a good first PR P-low Low priority issues

Comments

@Kixiron
Copy link
Member

Kixiron commented Jul 7, 2020

Currently the CrateDetails struct has two fields of untyped JSON, authors_json and dependencies. This isn't good since it can lead to errors like #879's OOB template indexing.
@Kixiron Kixiron added C-technical-debt Category: This makes the code harder to read and modify, but has no impact on end users A-backend Area: Webserver backend labels Jul 7, 2020
@jyn514 jyn514 added the P-low Low priority issues label Jul 13, 2020
@syphar syphar added the E-easy Effort: Should be easy to implement and would make a good first PR label Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-backend Area: Webserver backend C-technical-debt Category: This makes the code harder to read and modify, but has no impact on end users E-easy Effort: Should be easy to implement and would make a good first PR P-low Low priority issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@syphar @jyn514 @Kixiron