Skip to content

CrateDetails should not be optional #884

Closed
@jyn514

Description

@jyn514

The more I look at this, the more I think this Option is not correct. If it's None, that means that no crate exists for the (name, version) pair:

return None;

So we should either unwrap() because we've guaranteed that this crate exists, or return a 404. I'm ok with making this a follow-up PR. The good news is this means the templates never have to handle the case when details is None.

Originally posted by @jyn514 in #879

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-frontendArea: Web frontendC-technical-debtCategory: This makes the code harder to read and modify, but has no impact on end usersP-lowLow priority issues

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions