CrateDetails should not be optional #884
Labels
A-frontend
Area: Web frontend
C-technical-debt
Category: This makes the code harder to read and modify, but has no impact on end users
P-low
Low priority issues
The more I look at this, the more I think this
Option
is not correct. If it'sNone
, that means that no crate exists for the (name, version) pair:docs.rs/src/web/crate_details.rs
Line 107 in 6a53a71
So we should either
unwrap()
because we've guaranteed that this crate exists, or return a 404. I'm ok with making this a follow-up PR. The good news is this means the templates never have to handle the case whendetails
is None.Originally posted by @jyn514 in #879
The text was updated successfully, but these errors were encountered: