Skip to content

Shows nothing if a crate has only prerelease versions #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bluss opened this issue Nov 8, 2016 · 2 comments
Closed

Shows nothing if a crate has only prerelease versions #80

bluss opened this issue Nov 8, 2016 · 2 comments
Labels
C-bug Category: This is a bug

Comments

@bluss
Copy link
Member

bluss commented Nov 8, 2016

Current example: http://docs.rs/symtern/

The crate really has published versions, see https://docs.rs/crate/symtern/0.1.0-pre.0
@onur
Copy link
Member

onur commented Nov 9, 2016

Thanks for reporting. I'll try to fix this as soon as I can.

@onur onur added the C-bug Category: This is a bug label Nov 9, 2016
@onur onur mentioned this issue Nov 10, 2016
Closed
@onur onur closed this as completed in 67e0fc3 Nov 10, 2016
@bluss
Copy link
Member Author

bluss commented Nov 10, 2016

Thanks. I was surprised over the "*" behavior too, but I've become used to it

hadronized pushed a commit to hadronized/docs.rs that referenced this issue Nov 30, 2016
@onur
Return latest version if requested version is any
21f5caf 
I believe this is a bug in semver crate but according to NPM people, and
@steveklabnik; a version like "0.1.0-pre.0" or "0.1.0-beta.0" *is not a
real version* and any version that contains a pre-release string is getting
different treatment by semver.

IMO this is utterly wrong. Docs.rs is probably the first victim of this
behavior and it will affect more in future. `*` means any and it should
match any version. It doesn't matter if a version have a pre-release string
or not. Even older versions of node's semver were matching "*" for any
version. I don't know why they changed this behavior but I am not surprised
any means "anything except a version that contains pre-release" in JS
world.

Fixes: rust-lang#80
Ref: dtolnay/semver#98
@onur onur mentioned this issue Mar 21, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@onur @bluss