Skip to content

Add dependency #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
19h opened this issue Oct 16, 2019 · 7 comments
Closed

Add dependency #436

19h opened this issue Oct 16, 2019 · 7 comments
Assignees
Labels
C-build-failure Category: This is a crate that failed to build

Comments

@19h
Copy link

19h commented Oct 16, 2019

Crate name: traildb-sys
Build failure link: https://docs.rs/crate/traildb-sys/0.6.0/builds/192057

Additional details:
I just published a new low-level crate supporting the traildb crate in providing a high-level API to TrailDB. This depends on Judy (http://judy.sourceforge.net/). Is it possible to add that dependency?

Thanks! 🐻

@19h 19h added the C-build-failure Category: This is a crate that failed to build label Oct 16, 2019
@GuillaumeGomez
Copy link
Member

@pietroalbini @QuietMisdreavus It'd be really nice to start explaining to people how to handle doc generation without enforcing external libraries dependencies.

pietroalbini added a commit to rust-lang/crates-build-env that referenced this issue Oct 17, 2019
@pietroalbini pietroalbini self-assigned this Oct 17, 2019
@pietroalbini
Copy link
Member

Thanks for reporting this @19h!

I pushed a commit to add libjudy-dev (from Ubuntu 18.04 LTS) to the build environment. I'll check back in in a few hours once the environment rebuild is complete to schedule a build of your crate.

@pietroalbini
Copy link
Member

@GuillaumeGomez it's actually good that people report missing dependencies and that we add them, as the build environment is also used by Crater which needs to actually build and sometimes test the crates.

@GuillaumeGomez
Copy link
Member

The two should be separated from my point of view. Testing a crate and documenting it are two very different things.

@pietroalbini
Copy link
Member

@19h did a rebuild, but it seems like libarchive-dev is also missing. Added it rust-lang/crates-build-env@9dda900, will need to wait for the environment rebuild to happen.

@19h
Copy link
Author

19h commented Oct 17, 2019

@pietroalbini thanks for adding the dependencies!

@pietroalbini
Copy link
Member

The docs are live! https://docs.rs/traildb-sys/0.6.3/traildb_sys/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-build-failure Category: This is a crate that failed to build
Projects
None yet
Development

No branches or pull requests

3 participants