Skip to content

Some releases where missed to build #1912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
conqp opened this issue Nov 17, 2022 · 5 comments
Open

Some releases where missed to build #1912

conqp opened this issue Nov 17, 2022 · 5 comments

Comments

@conqp
Copy link

conqp commented Nov 17, 2022

Crate name

ansi-color-codec

Build failure link

N/A

Additional details

I updated ansi-color-codec to 0.3.11 today, but it was never built on docs.rs.
It is neither in the queue nor is there a failed build logged for this version.
The docs build fine on my dev machine with rustdoc 1.63.0 (4b91a6ea7 2022-08-08).
Any idea what's going on?

0 ✓ rne@thinkpad ~/Projekte/ansi-color-codec $ git log -1
commit 58ad2c53055ca9a19ee2210299946b1d8f137c9e (HEAD -> main, tag: 0.3.11, github/main, github/HEAD)
Author: Richard Neumann <[email protected]>
Date:   Thu Nov 17 18:23:00 2022 +0100

    Add documentation and doctests
0 ✓ rne@thinkpad ~/Projekte/ansi-color-codec $ cargo clean
0 ✓ rne@thinkpad ~/Projekte/ansi-color-codec $ cargo doc
   Compiling proc-macro2 v1.0.47
   Compiling quote v1.0.21
   Compiling version_check v0.9.4
   Compiling syn v1.0.103
   Compiling unicode-ident v1.0.5
   Compiling libc v0.2.137
 Documenting unicode-ident v1.0.5
    Checking bitflags v1.3.2
    Checking cfg-if v1.0.0
    Checking os_str_bytes v6.4.0
 Documenting bitflags v1.3.2
   Compiling heck v0.4.0
    Checking once_cell v1.16.0
    Checking termcolor v1.1.3
 Documenting heck v0.4.0
 Documenting os_str_bytes v6.4.0
    Checking strsim v0.10.0
 Documenting cfg-if v1.0.0
 Documenting strsim v0.10.0
 Documenting once_cell v1.16.0
 Documenting termcolor v1.1.3
   Compiling proc-macro-error-attr v1.0.4
   Compiling proc-macro-error v1.0.4
    Checking clap_lex v0.3.0
 Documenting clap_lex v0.3.0
 Documenting proc-macro2 v1.0.47
 Documenting libc v0.2.137
 Documenting quote v1.0.21
 Documenting proc-macro-error-attr v1.0.4
 Documenting syn v1.0.103
    Checking nix v0.25.0
    Checking atty v0.2.14
 Documenting atty v0.2.14
 Documenting nix v0.25.0
    Checking ctrlc v3.2.3
 Documenting ctrlc v3.2.3
 Documenting proc-macro-error v1.0.4
 Documenting clap_derive v4.0.21
   Compiling clap_derive v4.0.21
 Documenting clap v4.0.25
    Checking clap v4.0.25
 Documenting ansi-color-codec v0.3.11 (/home/rne/Projekte/ansi-color-codec)
    Finished dev [unoptimized + debuginfo] target(s) in 20.36s
0 ✓ rne@thinkpad ~/Projekte/ansi-color-codec $ cargo test
   Compiling bitflags v1.3.2
   Compiling cfg-if v1.0.0
   Compiling os_str_bytes v6.4.0
   Compiling termcolor v1.1.3
   Compiling once_cell v1.16.0
   Compiling strsim v0.10.0
   Compiling clap_lex v0.3.0
   Compiling libc v0.2.137
   Compiling nix v0.25.0
   Compiling atty v0.2.14
   Compiling clap v4.0.25
   Compiling ctrlc v3.2.3
   Compiling ansi-color-codec v0.3.11 (/home/rne/Projekte/ansi-color-codec)
    Finished test [unoptimized + debuginfo] target(s) in 10.12s
     Running unittests src/lib.rs (target/debug/deps/ansi_color_codec-39e2b5a9a3334ba1)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running unittests src/main.rs (target/debug/deps/ansi_color_codec-a375e45a6c9fda92)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests ansi-color-codec

running 3 tests
test src/lib.rs - ColorCodec::ansi_color_decode (line 100) ... ok
test src/lib.rs - ColorCodec::ansi_color_encode (line 33) ... ok
test src/lib.rs - ColorCodec::interpret_as_ansi_colors (line 63) ... ok

test result: ok. 3 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.47s

0 ✓ rne@thinkpad ~/Projekte/ansi-color-codec $ cargo --version 
cargo 1.63.0 (fd9c4297c 2022-07-01)
0 ✓ rne@thinkpad ~/Projekte/ansi-color-codec $ 
@Nemo157
Copy link
Member

Nemo157 commented Nov 17, 2022

Looks like it wasn't seen for some reason, production logs from the registry checks before/after the publish event:

2022-11-17T17:25:29.611096Z DEBUG docs_rs::utils::daemon: Checking new crates
2022-11-17T17:25:30.357202Z DEBUG docs_rs::utils::daemon: 0 crates added to queue
2022-11-17T17:26:30.358280Z DEBUG docs_rs::utils::daemon: Checking new crates
2022-11-17T17:26:31.324289Z DEBUG docs_rs::build_queue: ansi-color-codec-0.3.5 yanked
2022-11-17T17:26:31.329799Z DEBUG docs_rs::build_queue: ansi-color-codec-0.3.4 yanked
2022-11-17T17:26:31.363771Z DEBUG docs_rs::utils::daemon: 0 crates added to queue

Relevant commits in https://github.com/rust-lang/crates.io-index:

> git log --format='%ai %h %s' --since='2022-11-17 00:00' an/si/ansi-color-codec
2022-11-17 17:26:27 +0000 92c18bdf30a Yanking crate `ansi-color-codec#0.3.5`
2022-11-17 17:26:25 +0000 1533f8e863a Yanking crate `ansi-color-codec#0.3.4`
2022-11-17 17:26:00 +0000 da97cd0243b Updating crate `ansi-color-codec#0.3.11`

It's likely a bug in crates-index-diff from having the update and yanks in the same check (maybe related to the major update it just had), I'll open an upstream issue and have manually queued a build.

@syphar
Copy link
Member

syphar commented Nov 18, 2022

@Nemo157 thank you for digging into this!

when fixed, is it worth running our consistency-check command? Does it still work?

@Nemo157
Copy link
Member

Nemo157 commented Nov 18, 2022

when fixed, is it worth running our consistency-check command? Does it still work?

Not sure, this should be very rare, I think it only happens when a crate is published and yanked multiple times within a minute to get picked up in the same index check. That said, it did already happen within two weeks of the crates-index-diff update 🙃

@Byron
Copy link
Member

Byron commented Nov 22, 2022

The latest version of crates-index-diff has received a major upgrade for correctness and performance, along with new baseline tests that validate no crates-index events are lost.

@syphar syphar changed the title ansi-color-codec 0.3.11 was never attempted to build Some releases where missed to build Dec 1, 2022
@syphar
Copy link
Member

syphar commented Dec 1, 2022

#1935 was merged & deployed, which should fix this reliably.

Since we need to find other releases we missed for this to be really solved, I'll leave this issue open until we ran (and fixed?) the consistency check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants