Don't manually escape names

Author: Kixiron

templates/core/home.html

@@ -34,13 +34,10 @@ <h1 class="brand"><i class="fa fa-cubes fa-fw"></i> Docs.rs</h1>
 
             <ul>
                 {%- for release in recent_releases -%}
-                    {# FIXME: https://github.com/Keats/tera/issues/539 #}
-                    {%- set name = release.name | escape -%}
-                    {%- set version = release.version | escape -%}
                     {%- if release.rustdoc_status -%}
-                        {%- set release_url = "/" ~ name ~ "/" ~ version ~ "/" ~ release.target_name -%}
+                        {%- set release_url = "/" ~ release.name ~ "/" ~ release.version ~ "/" ~ release.target_name -%}
                     {%- else -%}
-                        {%- set release_url = "/crate/" ~ name ~ "/" ~ version -%}
+                        {%- set release_url = "/crate/" ~ release.name ~ "/" ~ release.version -%}
                     {%- endif -%}
 
                     <li>

templates/header/package_navigation.html

@@ -54,10 +54,7 @@ <h1 id="crate-title">
 
                 <ul class="pure-menu-list">
                     {# The partial path of the crate, `:name/:release` #}
-                    {# FIXME: https://github.com/Keats/tera/issues/539 #}
-                    {%- set name = metadata.name | escape -%}
-                    {%- set version = metadata.version | escape -%}
-                    {%- set crate_path = name ~ "/" ~ version -%}
+                    {%- set crate_path = metadata.name ~ "/" ~ metadata.version -%}
 
                     {# If docs are built, show a tab for them #}
                     {%- if metadata.rustdoc_status -%}

templates/macros.html

@@ -88,12 +88,9 @@
 {% macro releases_list(name, releases) %}
     {%- for release in releases -%}
         {# The url for the release, `/crate/:name/:version` #}
-        {# FIXME: https://github.com/Keats/tera/issues/539 #}
-        {%- set name = name | escape -%}
-        {%- set version = release.version | escape -%}
-        {%- set release_url = "/crate/" ~ name ~ "/" ~ version -%}
+        {%- set release_url = "/crate/" ~ name ~ "/" ~ release.version -%}
         {# The release's name and version, `:name-:version` #}
-        {%- set release_name = name ~ "-" ~ version -%}
+        {%- set release_name = name ~ "-" ~ release.version -%}
 
         <li class="pure-menu-item">
             {# If the release isn't a library, then display that warning #}

templates/releases/feed.xml

@@ -12,20 +12,17 @@
     <updated>{{ recent_releases[0].release_time | default(value=now()) | date(format="%+") }}</updated>
 
     {%- for release in recent_releases -%}
-        {# FIXME: https://github.com/Keats/tera/issues/539 #}
-        {%- set name = release.name | escape_xml -%}
-        {%- set version = release.version | escape_xml -%}
         {%- if release.rustdoc_status -%}
-            {%- set link = "/" ~ name ~ "/" ~ version ~ "/" ~ release.target_name -%}
+            {%- set link = "/" ~ release.name ~ "/" ~ release.version ~ "/" ~ release.target_name -%}
         {%- else -%}
-            {%- set link = "/crate/" ~ name ~ "/" ~ version -%}
+            {%- set link = "/crate/" ~ release.name ~ "/" ~ release.version -%}
         {%- endif %}
 
         <entry>
-            <title>{{ name }}-{{ version }}</title>
+            <title>{{ release.name }}-{{ version }}</title>
 
             <link href="{{ link | safe }}" />
-            <id>urn:docs-rs:{{ name }}:{{ version }}</id>
+            <id>urn:docs-rs:{{ release.name }}:{{ version }}</id>
             <updated>{{ release.release_time | date(format="%+") }}</updated>
 
             <summary>

templates/releases/releases.html

@@ -21,12 +21,10 @@
             <ul>
                 {# TODO: If there are no releases, then display a message that says so #}
                 {%- for release in releases -%}
-                    {%- set name = release.name | escape -%}
-                    {%- set version = release.version | escape -%}
                     {%- if release.rustdoc_status -%}
-                        {% set link = "/" ~ name ~ "/" ~ version ~ "/" ~ release.target_name -%}
+                        {% set link = "/" ~ release.name ~ "/" ~ release.version ~ "/" ~ release.target_name -%}
                     {%- else -%}
-                        {% set link = "/crate/" ~ name ~ "/" ~ version -%}
+                        {% set link = "/crate/" ~ release.name ~ "/" ~ release.version -%}
                     {%- endif -%}
 
                     <li>

templates/rustdoc/body.html

@@ -1,10 +1,7 @@
 {%- import "macros.html" as macros -%}
 
 {# The url of the current release, `/crate/:name/:version` #}
-{# FIXME: https://github.com/Keats/tera/issues/539 #}
-{%- set name = krate.name | escape -%}
-{%- set version = krate.version | escape -%}
-{%- set crate_url = "/crate/" ~ name ~ "/" ~ version -%}
+{%- set crate_url = "/crate/" ~ krate.name ~ "/" ~ krate.version -%}
 
 <div class="nav-container nav-container-rustdoc">
     <div class="container-rustdoc rustdoc-navigation">