Skip to content

Commit b731f84

Browse files
Nemo157Joshua Nelson
authored andcommitted
Use a custom environment variable to configure logging
1 parent d58f595 commit b731f84

File tree

4 files changed

+20
-22
lines changed

4 files changed

+20
-22
lines changed

.env.sample

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
CRATESFYI_PREFIX=ignored/cratesfyi-prefix
22
CRATESFYI_DATABASE_URL=postgresql://cratesfyi:password@localhost:15432
3-
RUST_LOG=cratesfyi,rustwide=info
3+
DOCSRS_LOG=cratesfyi,rustwide=info
44
AWS_ACCESS_KEY_ID=cratesfyi
55
AWS_SECRET_ACCESS_KEY=secret_key
66
S3_ENDPOINT=http://localhost:9000

dockerfiles/entrypoint.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ set -euv
44

55
export CRATESFYI_PREFIX=/opt/docsrs/prefix
66
export DOCS_RS_DOCKER=true
7-
export RUST_LOG=${RUST_LOG-cratesfyi,rustwide=info}
7+
export DOCSRS_LOG=${DOCSRS_LOG-cratesfyi,rustwide=info}
88
export PATH="$PATH:/build/target/release"
99

1010
# Try migrating the database multiple times if it fails

src/bin/cratesfyi.rs

Lines changed: 15 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -33,25 +33,21 @@ pub fn main() {
3333
fn logger_init() {
3434
use std::io::Write;
3535

36-
let mut builder = env_logger::Builder::new();
37-
builder.format(|buf, record| {
38-
writeln!(
39-
buf,
40-
"{} [{}] {}: {}",
41-
time::now().strftime("%Y/%m/%d %H:%M:%S").unwrap(),
42-
record.level(),
43-
record.target(),
44-
record.args()
45-
)
46-
});
47-
builder.parse_filters(
48-
env::var("RUST_LOG")
49-
.ok()
50-
.as_deref()
51-
.unwrap_or("cratesfyi=info"),
52-
);
53-
54-
rustwide::logging::init_with(builder.build());
36+
let env = env_logger::Env::default().filter_or("DOCSRS_LOG", "cratesfyi=info");
37+
let logger = env_logger::from_env(env)
38+
.format(|buf, record| {
39+
writeln!(
40+
buf,
41+
"{} [{}] {}: {}",
42+
time::now().strftime("%Y/%m/%d %H:%M:%S").unwrap(),
43+
record.level(),
44+
record.target(),
45+
record.args()
46+
)
47+
})
48+
.build();
49+
50+
rustwide::logging::init_with(logger);
5551
}
5652

5753
#[derive(Debug, Clone, Copy, PartialEq, Eq, strum::EnumString, strum::EnumVariantNames)]

src/test/mod.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,9 @@ pub(crate) struct TestEnvironment {
104104

105105
pub(crate) fn init_logger() {
106106
// If this fails it's probably already initialized
107-
let _ = env_logger::builder().is_test(true).try_init();
107+
let _ = env_logger::from_env(env_logger::Env::default().filter("DOCSRS_LOG"))
108+
.is_test(true)
109+
.try_init();
108110
}
109111

110112
impl TestEnvironment {

0 commit comments

Comments
 (0)