some more minor fixes #76
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tinaun
commented
Jan 26, 2021
tinaun
commented
- actually fix crates without descriptions
- support searching for items in non-std crates
ibraheemdev
reviewed
Jan 27, 2021
src/crates.rs
Outdated
| @@ -48,7 +50,7 @@ pub fn search(args: Args) -> Result<(), Error> { | |||
| m.embed(|e| { | |||
| e.title(&krate.name) | |||
| .url(format!("https://crates.io/crates/{}", krate.id)) | |||
| .description(&krate.description) | |||
| .description(krate.description.as_ref().map_or("", |e| e.as_str())) | |||
There was a problem hiding this comment.
couldn't this be &krate.description.unwrap_or_default()?
…inform them about the error
additional src/state_machine.rs changes: - Updated the CharacterSet - remove now takes a slice of chars instead of a single char - added a from_chars method that takes a slice of chars to initialize a CharacterSet without additional steps.
support `2021` as arguments in play and eval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.