Migrate the frontend to use the new yank API

[0xPoe]

Moved to the new API before adding frontend support for the yank message.

Tested locally:

Screen.Recording.2024-10-27.at.16.40.16.mov

[0xPoe]

🔢 Self-check (PR reviewed by myself and ready for feedback.)

[Turbo87]

we should update the yank status and add the yank_message field here and then return the serialized version. note that there is also a test suite for the mirage route handlers to ensure that it roughly matches the real API that we are mocking here. if we implement the frontend code against an API that does not match the real API we're in for trouble 😅

[0xPoe]

I followed the previous mock API 😅

  server.delete('/api/v1/crates/:name/:version/yank', (schema, request) => {
    const { name, version: versionNum } = request.params;
    const crate = schema.crates.findBy({ name });
    if (!crate) {
      return notFound();
    }

    const version = schema.versions.findBy({ crateId: crate.id, num: versionNum });
    if (!version) {
      return notFound();
    }

    return {};
  });

  server.put('/api/v1/crates/:name/:version/unyank', (schema, request) => {
    const { name, version: versionNum } = request.params;
    const crate = schema.crates.findBy({ name });
    if (!crate) {
      return notFound();
    }

    const version = schema.versions.findBy({ crateId: crate.id, num: versionNum });
    if (!version) {
      return notFound();
    }

    return {};
  });

Do we need to update the old one as well? Or just delete it?

[Turbo87]

ouch, wow, yeah, those are definitely wrong 🙈

[0xPoe]

Alright, I’ll update it as well. Initially, I thought we were focusing only on UI testing(we only checked the button name), so I didn’t consider the actual version status. I’ll make sure to update the version status correctly.

[Turbo87]

I thought we were focusing only on UI testing(we only checked the button name), so I didn’t consider the actual version status

we have the "crates can be yanked by owner" test, but that apparently only asserts local state, which meant that the bug in the mirage implementation was hidden. and apparently we currently don't have any tests for the yank/unyank endpoints in mirage 😢

[0xPoe]

🔢 Self-check (PR reviewed by myself and ready for feedback.)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.80%. Comparing base (6f264d0) to head (d552553).
Report is 29 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9765      +/-   ##
==========================================
- Coverage   88.80%   88.80%   -0.01%     
==========================================
  Files         289      289              
  Lines       29817    29808       -9     
==========================================
- Hits        26480    26470      -10     
- Misses       3337     3338       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.