Better error messages for empty string ENV variables #940
+9
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vignesh-sankaran
commented
Aug 7, 2017
src/tests/all.rs
Outdated
| @@ -138,11 +138,17 @@ fn app() -> (record::Bomb, Arc<App>, conduit_middleware::MiddlewareBuilder) { | |||
| return (bomb, app, middleware); | |||
| } | |||
|
|
|||
| /// Returnx the environment variable only if it has been defined | |||
There was a problem hiding this comment.
Are doc comments visible in integration tests? I don't think they are.
There was a problem hiding this comment.
AFAIK tests don't show up in documentation at all. While you're changing this to be a regular comment, could you remove the stray "x" at the end of "Returnx" too please? :)
carols10cents
requested changes
Aug 9, 2017
src/tests/all.rs
Outdated
| @@ -138,11 +138,17 @@ fn app() -> (record::Bomb, Arc<App>, conduit_middleware::MiddlewareBuilder) { | |||
| return (bomb, app, middleware); | |||
| } | |||
|
|
|||
| /// Returnx the environment variable only if it has been defined | |||
There was a problem hiding this comment.
AFAIK tests don't show up in documentation at all. While you're changing this to be a regular comment, could you remove the stray "x" at the end of "Returnx" too please? :)
carols10cents
approved these changes
Aug 14, 2017
|
bors: r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Aug 14, 2017
940: Better error messages for empty string ENV variables r=carols10cents Fixes up #937, which was caused by me not having the `TEST_DATABASE_URL` set i.e. it was `TEST_DATABASE_URL=`. Thanks to Arnavion on the #rust channel for pointing out I could use unwrap_or() to cover both the `None` and `""` cases at once :).
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes up #937, which was caused by me not having the
TEST_DATABASE_URLset i.e. it wasTEST_DATABASE_URL=. Thanks to Arnavion on the #rust channel for pointing out I could use unwrap_or() to cover both theNoneand""cases at once :).